Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-optin News banner not (fully) visible in non-full screen view ports #36770

Closed
Tracked by #35960
LorenzoMinto opened this issue Mar 13, 2024 · 5 comments
Closed
Tracked by #35960

Pre-optin News banner not (fully) visible in non-full screen view ports #36770

LorenzoMinto opened this issue Mar 13, 2024 · 5 comments
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude

Comments

@LorenzoMinto
Copy link

LorenzoMinto commented Mar 13, 2024 •
edited
Loading

Related to #35112

I'm on a 15'' screen, not full screen.
Screenshot 2024-03-13 at 17 45 54
Screenshot 2024-03-13 at 17 46 10
Second screenshot is after I increase the window size. The news banner seems to be lower than the toolbar.
@LorenzoMinto LorenzoMinto mentioned this issue Mar 13, 2024
Open
@LorenzoMinto LorenzoMinto added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude OS/Desktop feature/brave-news formerly brave-today labels Mar 13, 2024
@LorenzoMinto LorenzoMinto changed the title Pre-optin News flag not visibile in not maximized view ports Pre-optin News banner not visibile in not maximized view ports Mar 13, 2024
@LorenzoMinto
Copy link
Author

cc @petemill @fallaciousreasoning

@MadhaviSeelam
Copy link

linking couple of related issues:
#26296
#23314

@LorenzoMinto LorenzoMinto added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 25, 2024
@LorenzoMinto LorenzoMinto added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Apr 8, 2024
@LorenzoMinto
Copy link
Author

Another screenshot from the latest nightly (with search bar). This is at the largest window size before full screen on a 15'' screen
Screenshot 2024-04-08 at 17 48 58

@LorenzoMinto LorenzoMinto changed the title Pre-optin News banner not visibile in not maximized view ports Pre-optin News banner not visibile/fully visible in non-full screen view ports Apr 8, 2024
@LorenzoMinto LorenzoMinto changed the title Pre-optin News banner not visibile/fully visible in non-full screen view ports Pre-optin News banner not (fully) visible in non-full screen view ports Apr 8, 2024
@MadhaviSeelam
Copy link

News peeking card is shown currently however, without Stats & Widgets on my 14" Windows laptop. I've enabled clock in this screenshot. Below is the screen resolution

image

Brave | 1.70.92 Chromium: 128.0.6613.85 (Official Build) beta (64-bit)
-- | --
Revision | 711f50838f629ac2be4d1d9592f72adecfd3c928
OS | Windows 11 Version 23H2 (Build 22631.4037)
image

@MadhaviSeelam
Copy link

closing this issue as this is dup of #39367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LorenzoMinto @MadhaviSeelam