Controls in the new tab page (Customize, Bookmarks, History & Brave talk) are hidden or partially visible in all view port sizes

[MadhaviSeelam]

Description

Found while testing #34593. Noticed couple of issues with regard to Controls in the new tab page (Customize, Bookmarks, History & Brave talk).

1. Before enabling news:

• In 1.62.x, after completing onboarding, (before enabling news) controls in the new tab page (Customize, Bookmarks, History & Brave talk) are only partially visible. Closed and relaunched Brave, all four controls are completely hidden

2. After enabling news:

• Controls are not visible. However, I can only view controls if I close the clock widget before scrolling down to view news feed

In comparison, controls are visible in all viewports size in 1.61.x
 

Steps to Reproduce

1. Install 1.62.129
2. launch Brave
3. complete onboarding
4. controls in the new tab page (Customize, Bookmarks, History & Brave talk) are partially visible in 21.5" view port and they are not visible at all in smaller screen sizes
5. close and relaunch Brave (do not enable news)
6. controls are hidden for all sizes
7. enable news
8. closed clock widget

Actual result:

Controls in the new tab page are either partially visible or not visible in all screen sizes. They can only viewed if clock widget or any other widget is closed in the new tab page.

1.62.x

1.62x.mp4

1.61.x

161x.mp4

Expected result:

Controls in the new tab page (Customize, Bookmarks, History & Brave talk) should be visible?

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.62.129 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | be1405d346b33750ce1b2b8e2a3b9e8ce84847c4
OS | Windows 11 Version 22H2 (Build 22621.2861)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @LorenzoMinto
cc: @stephendonner @rebron

[rebron]

cc: @aguscruiz

[aguscruiz]

I can only think of a way to solve this problem where the Rewards card (or any other card) has an inner scroll on the content and so we can limit the total height of the card so it doesn't extend beyond the window height.

This way everything can fit in the screen and also show the bottom options

[fallaciousreasoning]

This might be fixed by brave/brave-core#22325

[MadhaviSeelam]

This is no longer an issue as above mentioned controls on 14" inch laptop except for Customize button are removed/hidden

Brave | 1.70.92 Chromium: 128.0.6613.85 (Official Build) beta (64-bit)
-- | --
Revision | 711f50838f629ac2be4d1d9592f72adecfd3c928
OS | Windows 11 Version 23H2 (Build 22631.4037)

[rebron]

Closing per last comment.