-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tipping panel view not showing on some YouTube channels #3335
Comments
This publisher has turned off embedding for all of their videos. We cannot get the publisher information when they have this turned off. Go to: The panel shows the publisher on their channel page. This is not due to localization as other Korean language videos show up properly: For the above publisher, you can see the info we use at: |
@NejcZdovc How should we handle the panel for publisher videos that have embedding disabled? |
@jasonrsadler if we get 401 let's get info from the page |
@NejcZdovc Does this need to be uplifted to 62.x, make the appropriate PR and tag us again please. |
@rebron we have uplift for 0.63 brave/brave-core#2092 |
Verification passed on
Used test plan from brave/brave-core#1756 |
@NejcZdovc The issue is still reproducible for a few YT videos. When the video is opened in a new tab, pubs info will not be shown in BR panel. https://drive.google.com/open?id=1mWcZnwy3z0mmk0id8Wj6cOBFpzCkErxa
|
@NejcZdovc I'm on latest master (0.65) and no media publishers are showing for me (youtube or twitch). |
Verification passed on
Used test plan from brave/brave-core#1756 and #3335 (comment) Verified passed with
Verification passed on
Used test plan from brave/brave-core#1756 and #3335 (comment) |
Issue: Tipping panel not showing on some YouTube channels when they should be. Tipping interface only shows "Rewards Summary" view.
Platform: MacOS,
0.59.35
.Reproduce: Navigate to https://www.youtube.com/watch?v=9y2EvgxxMXc, and open the tipping panel.
Should show tipping view.
Notes: Early suspicions are that this related to localization, as this channel is in Korean.
The text was updated successfully, but these errors were encountered: