-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Add support for Certificate Transparency in Brave #22482
Comments
|
The reason CT enforcement is disabled in Brave is that the RequireCTDelegate doesn't change the default CT policy. This delegate is set based on Removing the
I was able to make the test page work. |
Before we enable this, we need to ensure that SCT auditing is turned off and not sending any data. See https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/chrome_features.cc;l=864-872;drc=a8473792f0f00c3574886d861118219f54fd3620 for the feature flag. |
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
Verification
|
Brave | 1.53.67 Chromium: 114.0.5735.53 (Official Build) beta (x86_64) |
---|---|
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970} |
OS | macOS Version 11.7.7 (Build 20G1345) |
Steps:
- installed
1.53.67
- launched Brave
- opened
https://no-sct.badssl.com
in Brave - confirmed the TLS error page with code
NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED
- opened
https://sct-exempted.bravesoftware.com
in Chrome - confirmed the TLS error page
NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED
- opened
https://sct-exempted.bravesoftware.com
in Brave - confirmed that the page loaded fine
- opened the same page in Chrome
- confirmed I got the above ERR_CERTIFICATE... page
no-sct.badssl.com Brave |
no-sct.badssl.com Chrome |
sct-exempted.bravesoftware.com/ Brave |
sct-exempted.bravesoftware.com Chrome |
---|---|---|---|
Verification
|
no-sct.badssl.com Brave |
no-sct.badssl.com Chrome |
sct-exempted.bravesoftware.com/ Brave |
sct-exempted.bravesoftware.com Chrome |
---|---|---|---|
We currently don't enforce certificate transparency in Brave, unlike Chrome and Safari.
This is what the interstitial looks like like Chrome:
It involves the PKI metadata component, which we enable in Brave, the
ERR_CERTIFICATE_TRANSPARENCY_REQUIRED_ERROR
error code as well as these feature flags:Turning on these flags in
brave://flags
doesn't help:The text was updated successfully, but these errors were encountered: