DCHECK in LocalStorageImpl::DeleteStorage

[goodov]

[446424:1:0803/232357.597546:FATAL:local_storage_control.mojom.cc(594)] Check failed: !connected. LocalStorageControl::DeleteStorageCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe.

Related: #16920

[goodov]

The test case which we can try to do here:

1. Use a slow machine
2. Open https://dev-pages.bravesoftware.com/storage/frames.html and store some value
3. Close the page, reopen it and make sure the value is stored in "This page" and "Local frame".
4. Continuously open/close the test page https://dev-pages.bravesoftware.com/storage/frames.html

Expected result: values should always be available.

[GeetaSarvadnya]

Verification passed on

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

• Verified the cases mentioned via Site settings don't get saved #17859 (comment)
• Verified the test plan from mentioned via DCHECK in LocalStorageImpl::DeleteStorage #17325 (comment), verified this issue on physical machine as well as on VM (with 2 processors and 4 GB and 1 processor with 2 GB)

---

Verified passed with

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (x86_64)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 10.15.7 (Build 19H1323)

• Verified the cases mentioned via Site settings don't get saved #17859 (comment)
• Verified the test plan from mentioned via DCHECK in LocalStorageImpl::DeleteStorage #17325 (comment)

---

Verification passed on

Brave	1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	Ubuntu 18.04 LTS

• Verified the cases mentioned via Site settings don't get saved #17859 (comment)
• Verified the test plan from mentioned via DCHECK in LocalStorageImpl::DeleteStorage #17325 (comment)

[srirambv]

Verification passed on Oppo Reno 5 with Android 11 running 1.29.79 x64 build

• Verified test plan from Site settings don't get saved #17859 (comment). For YT only sets video resolution upto 720p which was retained
• Verified second test plan from DCHECK in LocalStorageImpl::DeleteStorage #17325 (comment)