Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Reorganize AndroidManifest.xml patching #15942

Open
samartnik opened this issue May 18, 2021 · 0 comments
Open

[Android] Reorganize AndroidManifest.xml patching #15942

samartnik opened this issue May 18, 2021 · 0 comments
Labels
dev-concern OS/Android Fixes related to Android browser functionality

Comments

@samartnik
Copy link
Contributor

Description

In order to reduce patching of chrome/android/java/AndroidManifest.xml we need to reorganize brave/android/java/AndroidManifest.xml to extend it and fill up appropriate blocks (extra_uses_permissions, extra_application_definitions, etc.).

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label May 18, 2021
@samartnik samartnik self-assigned this Jun 4, 2021
@samartnik samartnik removed their assignment Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

1 participant