Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Doubleclick ads not blocked on Core but blocked on Muon (orlandosentinel.com) #1428

Closed
Miyayes opened this issue Oct 4, 2018 · 3 comments · Fixed by brave/brave-core#592
Closed

Google Doubleclick ads not blocked on Core but blocked on Muon (orlandosentinel.com) #1428

Miyayes opened this issue Oct 4, 2018 · 3 comments · Fixed by brave/brave-core#592
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 4, 2018

Issue: 3rd party programmatic ads from Google not being blocked on Brave-core. Example: https://orlandosentinel.com. However, these ads are all blocked on the Muon browser. (Discovered by Brad Flora.)

Shields count (items blocked) on Muon 2-4x higher than on Core shields.

Example of advertisement coming through on Core: image
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Oct 5, 2018
@bbondy bbondy self-assigned this Oct 5, 2018
@bbondy
Copy link
Member

bbondy commented Oct 5, 2018

https://orlandosentinel.com seems down, is there another site?

@bbondy
Copy link
Member

bbondy commented Oct 5, 2018

https://www.orlandosentinel.com works

bbondy added a commit to brave/brave-core that referenced this issue Oct 9, 2018
@bbondy
Change adblock and TP from resource throttle to network delegate
348e2fc 
This also makes it so empty data urls are used by default instead of
blocking.  Empty image data URLs for images.

Fix brave/brave-browser#1430
Fix brave/brave-browser#1118
Fix brave/brave-browser#1428
Fix brave/brave-browser#1362
@bbondy bbondy added the QA/Yes label Oct 9, 2018
@bbondy bbondy mentioned this issue Oct 9, 2018
Merged
18 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2018 •
edited by srirambv
Loading

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Change adblock and TP from resource throttle to network delegate brave/brave-core
5 participants
@bbondy @Miyayes @srirambv @LaurenWags @GeetaSarvadnya