Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{numitems}} in brave://rewards instead of the actual number in Polish locale #13764

Closed
btlechowski opened this issue Jan 26, 2021 · 4 comments · Fixed by brave/brave-core#8181

Comments

@btlechowski
Copy link

Reproduces for One time tips and Monthly contributions

Steps to Reproduce

  1. Clean install
  2. Run Brave in Polish (PL) locale
  3. Join rewards
  4. Tip at least 6 verified publishers
  5. Open brave://rewards

Actual result:

Tips and Monthly contributions have {{numitems}} instead of the actual number
image
image
image

Expected result:

The actual number like in English locale
image

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
Brave 1.21.26 Chromium: 88.0.4324.96 (Oficjalna wersja) nightly (64-bitowa)
Wersja 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
System operacyjny Linux
Brave 1.19.86 Chromium: 88.0.4324.96 (Oficjalna wersja) (64-bitowa)
Wersja 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
System operacyjny Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @rebron @mkarolin @brave/legacy_qa

@emerick
Copy link
Contributor

emerick commented Mar 7, 2021

Seems like it should be named {{numItems}} not {{numitems}}. Not sure how the wrong capitalization got into the Polish .xtb file (it's the only occurence of that capitalization in our entire repo).

@mkarolin
Copy link
Contributor

mkarolin commented Mar 7, 2021

The case was incorrectly changed in Transifex during l10n. Corrected it in Transifex: https://www.transifex.com/brave/brave/translate/#pl/$/156854308?q=text%3A{{numitems}}

@emerick emerick self-assigned this Mar 7, 2021
@emerick
Copy link
Contributor

emerick commented Mar 7, 2021

Thanks @mkarolin!

@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Verified using the STR/Cases outlined via #13764 (comment).

Zrzut ekranu 2021-03-10 214127


Verified passed with

Brave | 1.21.76 Chromium: 89.0.4389.86 (Oficjalna wersja) (x86_64)
-- | --
Wersja | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
System operacyjny | macOS Wersja 10.15.7 (kompilacja 19H524)

Reproduced the original issue using 1.21.74 and STR from description:

Example Example
Zrzut ekranu 2021-03-11 o 10 28 36 Zrzut ekranu 2021-03-11 o 10 28 41

Verified number displays correctly using 1.21.76:

Example Example
Zrzut ekranu 2021-03-11 o 10 27 15 Zrzut ekranu 2021-03-11 o 10 27 21

Verification passed on

Brave 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment