npm audit_deps is not catching some advisories

[diracdeltas]

it should fail currently but passes

[diracdeltas]

@kjozwiak not sure whether to mark this QA/yes or QA/no. this doesn't introduce any new changes, but there is some risk of UI regressions since some npm dependencies were upgraded. in particular i would recommend making sure that stats show up correct on the NTP and that all tipping buttons work.

[kjozwiak]

We'll label this as QA/Yes so we can double check the affected area's you mentioned above 👍 1.21.x will be a major Chromium release as we're bumping from C88 --> C89 so QA will be running through full regression passes which checks the above areas as well. @diracdeltas does this affect Android as well? Assuming both share the same dependencies as they're on the same code base. If so, mind adding the OS/Android label?

[LaurenWags]

Verified passed with

Brave | 1.21.59 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
-- | --
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | macOS Version 10.15.7 (Build 19H512)

Verified suggested areas from #13562 (comment).
Confirmed in-line tip buttons for Twitter, GitHub, Reddit worked as expected.
Confirmed tips were deducted from wallet balance and recorded appropriately on brave://rewards page.
Confirmed NTP stats displayed as expected.

Screenshots

Twitter	GitHub	Reddit

brave://rewards wallet panel	Tips panel

NTP Stats

---

Verification passed on

Brave	1.21.64 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	Ubuntu 18.04 LTS

Verified suggested areas from #13562 (comment).
Confirmed in-line tip buttons for Twitter, GitHub, Reddit worked as expected.
Confirmed tips were deducted from wallet balance and recorded appropriately on brave://rewards page.
Confirmed NTP stats displayed as expected.

Screenshots

Twitter	GitHub	Reddit

brave://rewards wallet panel and Tips panel

NTP Stats

---

Verification passed on

Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified suggested areas from #13562 (comment).
Confirmed in-line tip buttons for Twitter, GitHub, Reddit worked as expected.
Confirmed tips were deducted from wallet balance and recorded appropriately on brave://rewards page.
Confirmed NTP stats displayed as expected.

Screenshots

Twitter	GitHub	Reddit

brave://rewards wallet panel	Tips panel

NTP Stats