Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password disclaimer missing from create account flow [Crypto Wallets] #12654

Closed
ryanml opened this issue Nov 12, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#193

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 12, 2020

Description

The password warning that appears under the first time import route should also appear for new account creation

Steps to Reproduce

  1. Opt in to Crypto Wallets
  2. Select "Create"

Actual result:

No disclaimer
Screen Shot 2020-11-11 at 5 37 33 PM

Expected result:

Should show disclaimer
Screen Shot 2020-11-11 at 5 41 05 PM

Reproduces how often:

100%

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.17.73 Chromium: 87.0.4280.67 (Official Build) (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Linux
Component 1.0.17 dev
  • Verified password disclaimer is shown when a new wallet is created
    image

Verification passed on

Brave 1.19.16 Chromium: 87.0.4280.66 (Official Build) nightly (64-bit)
Revision fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS Windows 10 OS Version 1809 (Build 17763.1577)
Component 1.0.17 dev
  • Verified password disclaimer is shown when a new wallet is created
    image

Verification passed on

Brave 1.18.56 Chromium: 87.0.4280.60 (Official Build) dev (x86_64)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS macOS Version 10.15.7 (Build 19H2)
Component 1.0.17 dev
  • Verified password disclaimer is shown when a new wallet is created
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment