Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Provide an in-browser-action UI way to detect when Crypto Wallets is not the selected web3 provider #11696

Closed
bbondy opened this issue Sep 14, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#195

Comments

@bbondy
Copy link
Member

bbondy commented Sep 14, 2020

Description

We have a setting for selecting the web3 provider here:
brave://settings/extensions

Screen Shot 2020-09-14 at 10 20 45 AM

However, we should also add an indication within our browser action button UI that tells the user when we're not the selected web3 provider.

This can be accomplished with an API which is currently already exposed to both Crypto Wallets and MetaMask:
chrome.braveWallet.getWeb3Provider. It returns the extension ID that is the current provider in a callback as the first param.

Steps to Reproduce

  1. Install MetaMask
  2. Verify in settings that Crypto Wallets is not the selected Dapp provider brave://settings/extensions (MetaMask will be)
  3. Go to brave://wallet and login so the Crypto Wallets extension gets loaded
  4. Open the browser action button for Crypto Wallets

Actual result:

No indication that Crypto Wallets is not the current web3 provider for Dapps.

Expected result:

Some indication should be there so a user doesn't wonder why it isn't the web3 provider.

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop labels Sep 14, 2020
@bbondy bbondy changed the title [Desktop] Provide an in-browser-action UI way to detect when Crypto Wallets is not the selected web3 provider Provide an in-browser-action UI way to detect when Crypto Wallets is not the selected web3 provider Sep 14, 2020
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 14, 2020
@srirambv srirambv changed the title Provide an in-browser-action UI way to detect when Crypto Wallets is not the selected web3 provider [Desktop] Provide an in-browser-action UI way to detect when Crypto Wallets is not the selected web3 provider Sep 14, 2020
@ryanml ryanml assigned marshall and unassigned ryanml Sep 24, 2020
@ryanml ryanml assigned ryanml and unassigned marshall Nov 19, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Nov 19, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Nov 20, 2020
@ryanml ryanml added this to the Ethereum Remote Client 1.0.24 milestone Nov 20, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Nov 20, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.17.73 Chromium: 87.0.4280.67 (Official Build) (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Linux
Component 1.0.17 Dev
  • Verified browser action UI shows info about CW not being the default web3 provider
    image
  • Verified clicking on settings opens up the settings page and sets focus to extensions

Verification passed on

Brave 1.19.31 Chromium: 87.0.4280.67 (Official Build) nightly (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 1809 (Build 17763.1577)
Component 1.0.17 Dev
  • Verified browser action UI shows info about CW not being the default web3 provider
    image
  • Verified clicking on settings opens up the settings page and sets focus to extensions

Verification passed on

Brave 1.18.61 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS macOS Version 10.15.7 (Build 19H2)
Component 1.0.17 Dev
  • Verified browser action UI shows info about CW not being the default web3 provider
    image
  • Verified clicking on settings opens up the settings page and sets focus to extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment