You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have in prefs external_wallets where we currently store uphold wallet. Uphold wallet is currently dictionary. All parsing is done in rewards_service_impl. We need to move this into shared lib.
remove general mojo typeExternalWallet and create specific types
create new structure in preferences
new object wallets
rename wallet into brave and move it in wallets
deprecate external_wallets
move external_wallets->uphold in wallets->uphold
Create new function GetWallet(string type) which will now return json string and all parsing should be done in shared lib
The text was updated successfully, but these errors were encountered:
On 1.15.x enabled Rewards and connected Uphold account. This is from my Preferences file:
Upgraded to 1.16.x and confirmed expected items in Preferences file:
Verification passed on
Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)
Right now we have in prefs
external_wallets
where we currently storeuphold
wallet. Uphold wallet is currently dictionary. All parsing is done inrewards_service_impl
. We need to move this into shared lib.remove general mojo type
ExternalWallet
and create specific typescreate new structure in preferences
wallets
wallet
intobrave
and move it inwallets
external_wallets
external_wallets->uphold
inwallets->uphold
GetWallet(string type)
which will now return json string and all parsing should be done in shared libThe text was updated successfully, but these errors were encountered: