This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Rewards should now respect main enable and autocontribute toggles #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
11 tasks
NejcZdovc
reviewed
Sep 15, 2018
| ledger_->GetPublisherInfo(filter, | ||
| std::bind(&BatPublishers::saveVisitInternal, this, | ||
| publisher_id, visit_data, duration, _1, _2)); | ||
| if (ledger_->GetRewardsMainEnabled() && ledger_->GetAutoContribute()) { |
There was a problem hiding this comment.
nit: we could just return if either of them are false, so that we don't have this big wrap @jasonrsadler
There was a problem hiding this comment.
#94 puts this in separate function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58
Unblocks brave/brave-core#419
Updates for Rewards to not save visit data when rewards is off. Also does not add to autocontribute when autocontribute is off.