Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1381 Add allow-forms into iframe sandbox #1382

Merged

Conversation

radoslavzeman
Copy link
Contributor

Strangely enough, we had to add allow-forms (not allow-presentation) into our iframe sandbox prop to make embedded PowerPoint presentations work.

@radoslavzeman radoslavzeman linked an issue Feb 20, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 20, 2025

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully built an image from path: next/

Copy link

@jankaBehal jankaBehal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Feb 20, 2025
@radoslavzeman radoslavzeman merged commit 15c4e80 into master Feb 20, 2025
11 checks passed
@radoslavzeman radoslavzeman deleted the 1381-bug-powerpoint-presentation-in-iframe-does-not-work branch February 20, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Powerpoint presentation in iframe does not work
2 participants