Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node maintenance #1369

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Node maintenance #1369

wants to merge 3 commits into from

Conversation

skifahrer
Copy link
Contributor

@skifahrer skifahrer commented Nov 28, 2024

Upgraded node versions and dependencies where possible.

Copy link

github-actions bot commented Nov 28, 2024

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: true

➡️ Changes in next: true

We are going to build 🚢

🔜 strapi

🔜 next

🥳 Bratiska-cli successfully built an image from path: strapi/
🥳 Bratiska-cli successfully built an image from path: strapi/
🥳 Bratiska-cli successfully built an image from path: next/
🥳 Bratiska-cli successfully built an image from path: next/

@skifahrer skifahrer marked this pull request as ready for review November 28, 2024 10:05
Comment on lines +39 to +45
"node": "18.x.x",
"npm": ">=9.8.1",
"yarn": "1.22"
},
"license": "MIT",
"volta": {
"node": "18.17.1",
"node": "18.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In next/Dockerfile, you use v20, here I see v18. Shouldn't it be the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants