Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1337 Change FileList item title from text to string #1338

Conversation

radoslavzeman
Copy link
Contributor

@radoslavzeman radoslavzeman commented Sep 16, 2024

  • change wrongly set title from "long" to "short" (from text to string)

Notes:

  • I checked if some of the titles are not longer that 256 characters - this would cause a problem in database when changing type of the field from text to string (string allows max 256 chars)
  • I tested it deployed on dev with current production DB - it works nicely

@radoslavzeman radoslavzeman linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 16, 2024

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: true

➡️ Changes in next: true

We are going to build 🚢

🔜 strapi

🔜 next

🥳 Bratiska-cli successfully built an image from path: strapi/
🥳 Bratiska-cli successfully built an image from path: next/

@radoslavzeman radoslavzeman marked this pull request as ready for review September 16, 2024 09:30
@radoslavzeman radoslavzeman requested a review from Ty-ci September 16, 2024 09:30
Copy link
Contributor

@Ty-ci Ty-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 nice

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Sep 16, 2024
@radoslavzeman radoslavzeman merged commit ecb8893 into master Sep 18, 2024
25 checks passed
@radoslavzeman radoslavzeman deleted the 1337-change-type-of-filelistitemtitle-from-text-to-string branch September 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change type of fileList.item.title from text to string
2 participants