Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate Azure MSAL secret used for org tree #1314

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Rotate Azure MSAL secret used for org tree #1314

merged 1 commit into from
Jul 22, 2024

Conversation

vidriduch
Copy link
Contributor

  • Remove old MSAL secret and secret example
  • Move secrets into separate folders based on the env they are deployed into
  • Add them to kustomize so they are deployed with the app. This was turned off before because it was not easy to managed these, but with added tooling we can start using this "feature" again

@vidriduch
Rotate Azure MSAL secret used for org tree
95050a5 
* Remove old MSAL secret and secret example
* Move secrets into seperate folders based on the env they are deployed into
* Add them to kustomize so they are deployed with the app. This was turned off before because it was not easy to managed these, but with added tooling we can start using this "feature" again
@vidriduch vidriduch requested a review from radoslavzeman July 22, 2024 11:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Jul 22, 2024
@radoslavzeman radoslavzeman merged commit 40f89fb into master Jul 22, 2024
13 of 14 checks passed
@radoslavzeman radoslavzeman deleted the rotate-msal-secret branch July 22, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoslavzeman radoslavzeman radoslavzeman approved these changes

Assignees
No one assigned
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidriduch @radoslavzeman