#1299 Update FileList component according to DS #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
katarinazaprazna
commented
Jun 28, 2024
•
katarinazaprazna
commented
- Add border to the list that displays files in rows
- Replace div markup with an unordered list and list items
Ty-ci
requested changes
Jul 1, 2024
| {fileSection?.files.map((file, fileIndex) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <div key={fileIndex} className="w-full"> | ||
| <li key={fileIndex} className="w-full"> | ||
| <FileCardWrapper fileItem={file} variant={variantFileList} /> |
There was a problem hiding this comment.
Here we can show the bottom divider of FIleCard based on whether it is the last child of the list or not.
Unfortunately we cannot simply use the class divide because the divider doesn't span the full width of the FileCard, so a prop needs to be drilled down through the FileCardWrapper into FileCard.
github-actions
bot
added
pr: needs work 🛠️
Ty-ci
approved these changes
Jul 2, 2024
| <FileCardWrapper | ||
| fileItem={file} | ||
| variant={variantFileList} | ||
| hideBottomDivider={fileIndex === (fileSection?.files?.length ?? false) - 1} |
There was a problem hiding this comment.
Suggested change
| hideBottomDivider={fileIndex === (fileSection?.files?.length ?? false) - 1} | |
| hideBottomDivider={fileIndex === fileSection.files.length - 1} |
Operators ?. and ?? are not needed, because the files array is defined. We use these only when necessary :)
github-actions
bot
added
pr: fix & ship 🚢
|
Test build pipeline info 🚀 🔜 next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.