Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Testimonials FE components #1240

Merged
merged 1 commit into from
Mar 27, 2024
Merged

add Testimonials FE components #1240

merged 1 commit into from
Mar 27, 2024

Conversation

radoslavzeman
Copy link
Contributor

  • add FE components to Testimonials section
  • testimonials render as <blockquote> with <cite> in <footer>
    • TODO this should be validated if it is correct html syntax
  • TODO render testimonials in unordered list

image

@radoslavzeman radoslavzeman requested a review from Ty-ci March 27, 2024 15:50
@radoslavzeman radoslavzeman force-pushed the feat/#1238-testimonials-fe-components branch from ebec9b4 to c01d9e6 Compare March 27, 2024 15:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully created an kustomize file.
🥳 Bratiska-cli successfully built an image from path: next/
🥳 Bratiska-cli successfully built an image from path: next/

Ty-ci
Ty-ci approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Ty-ci Ty-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine :)

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Mar 27, 2024
@radoslavzeman radoslavzeman merged commit 6a58f68 into master Mar 27, 2024
11 checks passed
@radoslavzeman radoslavzeman deleted the feat/#1238-testimonials-fe-components branch March 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ty-ci Ty-ci Ty-ci approved these changes

Assignees
No one assigned
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoslavzeman @Ty-ci