Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visuals #1190

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix visuals #1190

merged 1 commit into from
Feb 27, 2024

Conversation

Ty-ci
Copy link
Contributor

@Ty-ci Ty-ci commented Feb 27, 2024



Regulation detail page - tag is displayed with value instead of display text:
Image



Typo - missing "k":
Image



Some Regulations do not have icon:
Image



It looks like its wrapped twice into SectionWrapper:
Image



The top padding should be part of page layout, not part of the search section. When used in "Regulations list" section, it adds unwanted space:
Image


@Ty-ci Ty-ci requested a review from radoslavzeman February 27, 2024 09:05
@Ty-ci Ty-ci linked an issue Feb 27, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 27, 2024

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully created an kustomize file.
🥳 Bratiska-cli successfully built an image from path: next/

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Feb 27, 2024
@Ty-ci Ty-ci merged commit 61216c1 into master Feb 27, 2024
14 checks passed
@Ty-ci Ty-ci deleted the 1189/Regulation-visual-fixes branch February 27, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regulation visual fixes
2 participants