-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1093/search redesign #1150
1093/search redesign #1150
Changes from 1 commit
8726a45
817c82b
a220872
f98ab9e
7680fae
1e79f94
78314dd
c775746
c21793b
d6f8dd9
1adf937
dc3f830
4a6cec1
73d85a8
5e1145c
7792ffb
bfa80f4
6d45ade
c1f2f89
dbdc812
3ee6678
9d049b4
e35c4ff
6781e8a
a28883f
83f09fb
c9720cc
bdf5c55
0e805d4
0eaa359
5f305da
e9613e5
d81eec8
1c9d31f
c9eb592
1f03c91
c793ec6
5fd8a07
7d03ac0
1260787
0118b43
c98ae95
5ec2cc9
064fb5e
63070a6
de4a53b
abe053a
d8bea61
5df7549
4297b3a
91be2dd
5ea435f
3d8b2b1
5e5193f
6026188
b9f8729
5482748
710461e
22a684d
4081aed
67d030f
e2c490c
65c8cc5
82bb8fa
e058b3b
fd93624
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import { Typography } from '@bratislava/component-library' | ||
import Button from '@components/forms/simple-components/Button' | ||
import { useTranslations } from 'next-intl' | ||
import { Dispatch, SetStateAction } from 'react' | ||
|
@@ -36,30 +37,34 @@ const AdvancedSearchNew = ({ | |
|
||
const newSearch = ( | ||
<div className="flex flex-col items-start gap-8 self-stretch"> | ||
<h1 className="text-h1 font-semibold text-gray-800 lg:w-[800px]">{title}</h1> | ||
<Typography type="h1" className="text-gray-800 lg:w-[800px]"> | ||
{title} | ||
</Typography> | ||
<div className="flex w-full flex-col gap-y-2"> | ||
<SearchField | ||
className="flex w-full flex-col [&>*>input>button]:hidden" | ||
aria-label={t('search')} | ||
defaultValue={placeholder} | ||
value={input} | ||
name="Searchinput" | ||
onChange={(val) => { | ||
return setInput(val) | ||
}} | ||
onSubmit={handleSearch} | ||
> | ||
<Text slot="description" className="mb-1 font-semibold"> | ||
<div className="flex flex-col gap-y-1"> | ||
<Typography type="p" className="font-semibold text-gray-800"> | ||
Ty-ci marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{t('SearchPage.whatAreYouLookingFor')} | ||
</Text> | ||
<div className="relative"> | ||
<Input | ||
type="search" | ||
className="w-full rounded-lg border-2 py-5 pl-[60px] pr-6 text-gray-700" | ||
/> | ||
<Button className="absolute left-6 h-full" isDisabled startIcon={<SearchIcon />} /> | ||
</div> | ||
</SearchField> | ||
</Typography> | ||
<SearchField | ||
className="flex w-full flex-col [&>*>input>button]:hidden" | ||
Ty-ci marked this conversation as resolved.
Show resolved
Hide resolved
|
||
aria-label={t('search')} | ||
defaultValue={placeholder} | ||
value={input} | ||
name="Searchinput" | ||
onChange={(val) => { | ||
return setInput(val) | ||
}} | ||
Ty-ci marked this conversation as resolved.
Show resolved
Hide resolved
|
||
onSubmit={handleSearch} | ||
> | ||
<div className="relative"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cannot position There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<Input | ||
type="search" | ||
className="w-full rounded-lg border-2 py-5 pl-[60px] pr-6 text-gray-700" | ||
/> | ||
<Button className="absolute left-6 h-full" isDisabled startIcon={<SearchIcon />} /> | ||
</div> | ||
</SearchField> | ||
</div> | ||
</div> | ||
</div> | ||
) | ||
|
radoslavzeman marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import { ArrowRightIcon } from '@assets/ui-icons' | ||
import { Typography } from '@bratislava/component-library' | ||
import Button from '@components/forms/simple-components/Button' | ||
import { useTranslations } from 'next-intl' | ||
|
||
|
@@ -12,7 +13,9 @@ export const SearchResultsHeader = ({ title, handleShowMore }: SearchResultsHead | |
|
||
return ( | ||
<div className="flex flex-col flex-wrap items-baseline justify-between gap-y-2 text-gray-800 sm:flex-row"> | ||
<h2 className="text-size-h4">{title}</h2> | ||
<Typography type="h2" size="h4" className="text-gray-800"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Color is handled by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default color for Typography is gray-700, however in Figma we have gray-800 for this text There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this kind of situations, we always want confront and change Figma to follow design system rules. --> Write a comment to Figma and tag Patrik. |
||
{title} | ||
</Typography> | ||
<Button variant="black-link" endIcon={<ArrowRightIcon />} onPress={handleShowMore}> | ||
{t('SearchPage.moreResults')} | ||
</Button> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text-gray-800 lg:w-[800px]
this should not be needed. If it'sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default color for Typography is gray-700, however in Figma we have gray-800 for this text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅