Add check for blogpostcard if in carousel or grid #1149
Conversation
There was a problem hiding this comment.
Thank you for finding the issue.
Regarding to the solution, a component should not be dependent on the parent component and behave differently in a specific component (as BlogCard would behave differently in Carousel)
Better approach would be if Carousel gives some classes to its children. Specifically, <li> element should give its child "h-full" class.
In tailwind, you can address children like this [&>*]:h-full.
Please try to solve the issue as suggested and test properly.
github-actions
bot
added
pr: needs work 🛠️
daksas303
added
pr: needs review 🙏
and removed
pr: needs work 🛠️
| @@ -16,7 +17,7 @@ const EventCardShowcase = () => { | |||
| dateTo="2023-05-12T15:00:00Z" | |||
| imageSrc="https://cdn-api.bratislava.sk/strapi-homepage/upload/silvester_odpocitavanie_f45d8e6629.jpg" | |||
| imageSizes={generateImageSizes({ default: '272px', lg: '384px' })} | |||
| className="w-[272px] lg:w-96" | |||
| className="h-[14.5rem] w-[272px] lg:h-[18.75rem] lg:w-96" | |||
There was a problem hiding this comment.
Why combine rem and px?
(also on line 30)
There was a problem hiding this comment.
Just didn't care, because it's only in styleguide.
github-actions
bot
added
pr: fix & ship 🚢
|
Test build pipeline info 🚀 🔜 next |
BlogPostCardis used inside a carousel, then use full height and if in a grid then grid handles itself the height of the cards.