Smoothen event source parser by feeding in smaller chunks #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sachinpad
approved these changes
Feb 11, 2025
sachinpad
added a commit
that referenced
this pull request
Feb 11, 2025
…)" This reverts commit bc16819.
sachinpad
added a commit
that referenced
this pull request
Feb 11, 2025
ankrgyl
added a commit
that referenced
this pull request
Feb 12, 2025
Unverts #151 and fixes it. The issue is that when replaying the cache, for the first `0...n-1` chunks, we need to include a newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like several things, including the event parser (straight up CPU performance), and node's ability to interleave stream segments when running lots of concurrent streams, are worsened by having streams with enormous chunks.
This change splits the stream into newlines, which seems to produce much better results.