support anthropic structured outputs #142
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Done |
package.json
Outdated
| "packageManager": "[email protected]", | ||
| "resolutions": { | ||
| "zod": "3.22.4" | ||
| } |
There was a problem hiding this comment.
Hm I believe we've moved away from doing this (@manugoyal @ibolmo have context)
There was a problem hiding this comment.
In this PR's case, the version of zod was different between the proxy and SDK, which was causing some strange type errors. I guess we could manually ensure they are the same?
There was a problem hiding this comment.
I think the way we accomplished this in the past was by pinning it in pnpm-lock.yaml instead. @manugoyal or @ibolmo can help you do this the right way.
There was a problem hiding this comment.
Will defer to @ibolmo, as I was only familiar with the resolutions approach, but now see we are using overrides in other parts of the codebase, such as our internal repo. A quick google suggests that pnpm.overrides is preferred for pnpm projects.
There was a problem hiding this comment.
Yeah I did an override: https://github.com/braintrustdata/braintrust-sdk/pull/469/files.
I forget the exact reason (something something peer dependency), but if the override doesn't unblock you I can try to hop on and sort it out with you.
No description provided.