Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add app extension compatibility #291

Conversation

bsmith11
Copy link
Contributor

#290

This is the implementation that was used in PINCache: pinterest/PINCache#72

It has since been removed, but as far as I can tell, only because the feature requiring [UIApplication sharedApplication] was removed as well:
pinterest/PINCache#99

@demerino
Copy link
Member

Thanks for putting this PR together - we'll take a closer look in the next few days.

Because these changes return false when isAppExtension - we'll also want to add something to the analytics metadata to mark these events as being from an app extensions so they don't pollute our data.

@skunkworks
Copy link
Contributor

Thanks for opening this PR @bsmith11 . Your changes seem reasonable, but I think we have a little bit of work on our end to make analytics from app extensions more coherent. Our current plan is to merge this to a separate branch and work off of that before we merge to master.

@skunkworks skunkworks changed the base branch from master to app-extensions-support November 17, 2016 19:15
@skunkworks skunkworks merged commit 55b2a77 into braintree:app-extensions-support Nov 17, 2016
apascual pushed a commit to apascual/braintree_ios that referenced this pull request Aug 23, 2017
Refactor BTDataCollector and PPDataCollector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants