Bring package up to date #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84b79c7.
This was referenced Dec 12, 2023
alessandrofelder
approved these changes
Dec 13, 2023
| @@ -0,0 +1,2 @@ | |||
| def test_placeholder(): | |||
There was a problem hiding this comment.
Opened #23 to build on this PR.
|
Feedback from @carlocastoldi still very welcome! |
adamltyson
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Use intersect_with_plane() from newest vedo instead of the backported function * fix some vedo function calls still using lowerCamelCase instead of snake_case * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the package up to date and works with a fresh install of vedo et al.
Closes #10
This PR also includes #16 and #17, so it would be great if you could take a look @carlocastoldi. I've never actually used this package, so I just tried to get the examples to run.