261 postgres correlation #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Time gets now correctly converted
…61-Postgres-Correlation
…61-Postgres-Correlation
…61-Postgres-Correlation
…-Postgres-Correlation"
…-Postgres-Correlation"
…61-Postgres-Correlation
…61-Postgres-Correlation
…to 261-Postgres-Correlation
…61-Postgres-Correlation
…61-Postgres-Correlation
Quacck
requested changes
May 18, 2020
|
|
||
| MongoDatabase database = mongoClient.getDatabase(mongoConfig.getName()); | ||
| MongoCollection<Document> coll = database.getCollection(collection_name); | ||
| // System.out.println("INVOKE"); |
There was a problem hiding this comment.
Is this comment still needed?
core/src/main/java/org/bptlab/cepta/operators/DataToMongoDB.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/bptlab/cepta/operators/DataToMongoDB.java
Outdated
Show resolved
Hide resolved
Comment on lines
80
to
84
| if (ackFuture.get()){ | ||
| // System.out.println("Success"); | ||
| } else { | ||
| System.out.println("Failed"); | ||
| } |
There was a problem hiding this comment.
Please improve error handling or error logging. If its just logging, maybe add information for when (which input) it failed or why. Use our overall logger perhaps?
core/src/main/java/org/bptlab/cepta/operators/DataToPostgresDatabase.java
Show resolved
Hide resolved
core/src/test/java/org/bptlab/cepta/data-to-mongo-db/DataToMongoDBTests.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/bptlab/cepta/data-to-mongo-db/DataToMongoDBTests.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/bptlab/cepta/delay-shift-mongo/DelayShiftFunctionMongoTests.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/bptlab/cepta/delay-shift-mongo/DelayShiftFunctionMongoTests.java
Outdated
Show resolved
Hide resolved
Quacck
approved these changes
May 19, 2020
core/src/main/java/org/bptlab/cepta/operators/DataToPostgresDatabase.java
Show resolved
Hide resolved
core/src/main/java/org/bptlab/cepta/operators/DelayShiftFunctionMongo.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #261
Implements Lazy Schema creation for postgre dataToDatabase operator