Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency bpmn-js to v18 #189

Merged
merged 6 commits into from
Jan 17, 2025
Merged

deps: update dependency bpmn-js to v18 #189

merged 6 commits into from
Jan 17, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
bpmn-js ^17.0.1 -> ^18.0.0 age adoption passing confidence

Release Notes

bpmn-io/bpmn-js (bpmn-js)

v18.0.0

Compare Source

Breaking Changes
  • Require Node >= 20
  • Canvas is now a focusable element and provides better support for native browser behaviors. Focus can be controlled with new focus and restoreFocus APIs.
  • Keyboard is now implicitly bound to canvas SVG element. Calls to keyboard.bind and keyboard.bindTo now result with a descriptive console error and have no effect.

v17.11.1

Compare Source

v17.11.0

Compare Source

v17.10.0

Compare Source

  • CHORE: correct various type hints (#​2228)
  • FIX: pasting compensation activity without boundary event (#​2070)
  • FIX: lane resize constraints for se and nw direction (#​2209)
  • FIX: auto place elements vertically in sub-processes (#​2127)
  • FIX: hide lane label during direct editing
  • DEPS: update to [email protected]

v17.9.2

Compare Source

  • FIX: keep direction when collapsing pools (#​2208)

v17.9.1

Compare Source

  • FIX: show delete action for labels (#​2163)

v17.9.0

Compare Source

v17.8.3

Compare Source

  • FIX: add accessible label to drill down button (#​2194)

v17.8.2

Compare Source

  • FIX: do not suggest root elements in search (#​2143)

v17.8.1

Compare Source

  • FIX: gracefully handle missing process DI in drilldown (#​2180)
  • FIX: do not cause HTML validation errors on move preview (#​2179)
  • DEPS: update to [email protected]

v17.8.0

Compare Source

  • FEAT: keep global elements when deleting last participant (#​2175)
  • FIX: allow undo after deleting last participants and data store (#​1676)
  • FIX: allow styling markers with canvas.addMarker and css (#​2173)
  • CHORE: render flow markers as part of djs-visual (#​2173)
  • DEPS: update to [email protected]

v17.7.1

Compare Source

v17.7.0

Compare Source

v17.6.4

Compare Source

v17.6.3

Compare Source

v17.6.2

Compare Source

v17.6.1

Compare Source

v17.6.0

Compare Source

  • FEAT: add ability to type services and events (#​2121, #​2153)
  • FIX: remove preview on context pad close (#​2150)
  • FIX: use tagged template in error logging (#​2151)

v17.5.0

Compare Source

v17.4.0

Compare Source

v17.3.0

Compare Source

  • FEAT: auto-place elements vertically (#​2110)

v17.2.2

Compare Source

  • FIX: correct navigated viewer outline (#​2133)

v17.2.1

Compare Source

v17.2.0

Compare Source

  • FEAT: make popup menu keyboard navigatable
  • FIX: address various accessibility issues
  • FIX: correct various typing issues
  • DEPS: update to [email protected]
  • DEPS: update to [email protected]

v17.1.0

Compare Source

  • FEAT: handle splitting vertical lanes (#​2101)

v17.0.2

Compare Source

  • FIX: create hit boxes for vertical lanes (#​2093)

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label Nov 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 7, 2024
@nikku nikku self-assigned this Nov 14, 2024
@nikku nikku added ready Ready to be worked on and removed needs review Review pending labels Nov 14, 2024
@nikku
Copy link
Member

nikku commented Nov 14, 2024

I'll look into this once I find the time.

@nikku
Copy link
Member

nikku commented Nov 15, 2024

Some work done in this department:

Some further investigation:

  • While this update works (in principal) there is two observations:
    • SELECT ALL selects the labels, i.e. cancelation of default behavior does not seem to take place
    • A bunch of content security policy errors in the logs that require further investigation

To be resumed next week.

@renovate renovate bot force-pushed the renovate/bpmn-js-18.x branch from 054d7fb to e98bb3a Compare November 15, 2024 14:13
@barmac
Copy link
Member

barmac commented Nov 29, 2024

@nikku do you still plan to work on this or should be change the assignee?

@nikku
Copy link
Member

nikku commented Nov 29, 2024

I'm unassigning myself, would love to see someone else pick this up.

@nikku nikku removed their assignment Nov 29, 2024
@jarekdanielak
Copy link
Contributor

Here's my attempt to integrate implicit keyboard binding and get rid of the KeyboardBinding module.

Default VS Code key bindings that we use in modeling are disabled in package.json if custom BPMN editor is used. There's a little hack with focusedView == '' - it works cause our custom editor doesn't have any view identifies set. I haven't found a way for this to break anything. I also haven't found any other way to tell we're focused on our editor and not on some other app element like side panel, command pallet etc.

I also made sure we focus the canvas when active tab is changed to BPMN editor. VS Code does it by default, focusing text editor after you switch tabs. We also follow a bunch of other default behaviors: focus when file is open, keep focus in file explorer when file is previewed.

SELECT ALL selects the labels, i.e. cancelation of default behavior does not seem to take place

Works ✅

A bunch of content security policy errors in the logs that require further investigation

"Fixed". I don't think we can go along without inline styling, so I just set style-src to unsafe-inline.

@jarekdanielak jarekdanielak requested a review from barmac December 19, 2024 14:04
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Dec 19, 2024
@jarekdanielak jarekdanielak requested a review from nikku December 19, 2024 14:04
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Dec 19, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@barmac
Copy link
Member

barmac commented Dec 20, 2024

Given the recent change to autofocus, I'd say let's update this right away to v18.12.0, and revisit then.

@nikku nikku marked this pull request as draft January 2, 2025 08:04
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 2, 2025
@jarekdanielak
Copy link
Contributor

Looks like removing auto-focus doesn't break anything. BPMN editor now doesn't focus on hover which makes it work like any other VS code editor, great change.

@jarekdanielak jarekdanielak marked this pull request as ready for review January 7, 2025 09:48
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 7, 2025
@nikku
Copy link
Member

nikku commented Jan 7, 2025

#189 (comment)

Great to get confirmation. ⭐

@nikku
Copy link
Member

nikku commented Jan 7, 2025

I integration tested this. Seems like undo is still triggered twice (Linux, Ubuntu):

capture BvhFws_optimized

@nikku nikku marked this pull request as draft January 7, 2025 15:07
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 7, 2025
@jarekdanielak
Copy link
Contributor

I added my changes to the unreleased section for now. I'll take a couple of hours to try to add a bugfix to release all together.

@jarekdanielak jarekdanielak marked this pull request as ready for review January 15, 2025 10:19
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 15, 2025
@nikku
Copy link
Member

nikku commented Jan 15, 2025

@jarekdanielak What is the additional bug fix you want to incorporate? I thought we were done with fixing things 🙈?

The reason we want to update the CHANGELOG is that auto-release will kick in, and it is generally good to update it as part of a PR.

@jarekdanielak
Copy link
Contributor

@nikku we are done fixing things "broken" by new bpmn-js version. Now we could actually fix some user-facing bugs. 😉

With canvas focus handling our shortcuts now, I can fix standard shortcuts when in content editable elements (#92) and perhaps check the new lines issue (#115).

OK if we don't want multiple auto-release runs, I'll use this PR for some additional bugfixing and come back when it's done. Back to a draft. 🚧

@jarekdanielak jarekdanielak marked this pull request as draft January 15, 2025 11:14
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 15, 2025
@jarekdanielak
Copy link
Contributor

I pushed a fix to #92. You can now use all the standard keyboard shortcuts when editing task labels and annotations.

Since this was reported for macOS, I only fixed it for macOS. Can we verify that it works for both Linux (@nikku) and Windows (@philippfromme)?

Screen.Recording.2025-01-15.at.16.10.19.mov

@jarekdanielak jarekdanielak marked this pull request as ready for review January 15, 2025 15:11
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 15, 2025
@jarekdanielak jarekdanielak requested a review from nikku January 15, 2025 15:11
@philippfromme
Copy link
Contributor

Keyboard shortcuts are working on Windows.

Code_ehAEfPikmB

@nikku nikku dismissed their stale review January 17, 2025 13:03

Outdated.

nikku
nikku approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged + released, works from all ends 🎉

renovate bot and others added 6 commits January 17, 2025 18:37
@renovate @jarekdanielak
deps: update dependency bpmn-js to v18
8e5b238
@jarekdanielak
feat: implicit keyboard binding
bcf37a9 
Since `[email protected]` keyboard is implicitly bound to modeling canvas. There is no need to implement keyboard binding in the extension.
We only need to make sure that default VS Code shortcuts do not fire when we are focused on the canvas.

Additionally, we make sure that modeling canvas stays focused after switching tabs, following default VS Code behavior for different file types.
@jarekdanielak
chore: fix CSP
78b4ca6
@nikku @jarekdanielak
chore: add package task
2bcd892
@jarekdanielak
fix: make standard keyboard shortcuts work for macOS
6ede4b7 
Closes #92
@jarekdanielak
chore: release v0.22.0
e11cbee
@jarekdanielak jarekdanielak merged commit bf90d98 into main Jan 17, 2025
7 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 17, 2025
@jarekdanielak jarekdanielak deleted the renovate/bpmn-js-18.x branch January 17, 2025 17:46
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@barmac barmac Awaiting requested review from barmac

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@jarekdanielak jarekdanielak

Labels
dependencies Updates a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikku @barmac @jarekdanielak @philippfromme