Non editable list groups #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinussilvestrus
requested review from
a team,
marstamm and
barmac
and removed request for
a team
pinussilvestrus
requested review from
MaxTru,
nikku and
philippfromme
and removed request for
marstamm and
barmac
nikku
reviewed
Jul 16, 2021
| @@ -39,7 +39,8 @@ const DEFAULT_LAYOUT = { | |||
| * component: import('preact').Component, | |||
| * id: String, | |||
There was a problem hiding this comment.
Meta comment, just because I came across it: Plain types are supposed to be lower case, i.e. string, number, boolean. Otherwise we refer to actual instances of String (new String("FOO")) which is not desired for type hints.
| @@ -87,14 +88,14 @@ export default function ListGroup(props) { | |||
| useEffect(() => { | |||
|
|
|||
| // we already sorted as items were added | |||
| if (open && !newItemAdded) { | |||
| if (shouldSort && open && !newItemAdded) { | |||
There was a problem hiding this comment.
Can shouldSort change? If so we'd need to make it part of the effect, right?
| setOrdering(createOrdering(sortItems(items))); | ||
| } | ||
| }, [ open ]); | ||
|
|
||
| // (3) items were deleted | ||
| useEffect(() => { | ||
| if (prevItems && items.length < prevItems.length) { | ||
| if (shouldSort && prevItems && items.length < prevItems.length) { |
There was a problem hiding this comment.
See above: Can shouldSort change?
| @@ -39,7 +39,8 @@ const DEFAULT_LAYOUT = { | |||
| * component: import('preact').Component, | |||
| * id: String, | |||
| * items: Array<ListItemDefinition>, | |||
| * label: String | |||
| * label: String, | |||
| * shouldSort?: Boolean | |||
There was a problem hiding this comment.
Any reason to not simply call it sort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to have lists non-editable, which includes
Required by bpmn-io/bpmn-properties-panel#25