Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim whitespaces when user leaves the field #401

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Feb 24, 2025

Closes #309

Proposed Changes

Extra whitespaces at the end are trimmed in both text area and text field

Feb-24-2025 16-10-59

You can test this works via

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel -l bpmn-io/properties-panel#trim-whitespaces

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copy link
Contributor

@jarekdanielak jarekdanielak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@abdul99ahad abdul99ahad merged commit 9c49e70 into main Feb 25, 2025
10 of 11 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 25, 2025
@abdul99ahad abdul99ahad deleted the trim-whitespaces branch February 25, 2025 09:29
@nikku
Copy link
Member

nikku commented Feb 25, 2025

Great stuff + great steps to try out 👏

@nikku nikku requested a review from lmbateman February 25, 2025 09:39
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 25, 2025
@nikku
Copy link
Member

nikku commented Feb 25, 2025

@abdul99ahad I gave this a run and it does not seem to work consistently across the different places yet, i.e. consider Camunda 8 execution listeners (no trimming):

capture rbKbwN_optimized

We should fix it for at least our *-types, job type, listener type etc:

capture rbKbwN_optimized

Please create a follow-up issue to capture these limitations, or follow-up with a fix.

@abdul99ahad abdul99ahad mentioned this pull request Feb 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Review pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-trim leading whitespaces when pasting into property fields
3 participants