Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll focused element into view #360

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

nikku
Copy link
Member

@nikku nikku commented May 28, 2024

This ensures that a newly created (and focused) entry is in view:

capture Giz5NV_optimized

Related to #311

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 28, 2024
@nikku nikku requested review from a team, philippfromme and marstamm and removed request for a team May 28, 2024 09:05
@nikku nikku force-pushed the scroll-to-focused-element branch from 03d4d2c to e54d1e8 Compare May 28, 2024 09:06
@barmac
Copy link
Member

barmac commented May 28, 2024

I'm testing this with npx @bpmn-io/sr -l bpmn-io/properties-panel#scroll-to-focused-element bpmn-io/bpmn-js-properties-panel

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@nikku nikku merged commit 523ccd6 into main May 28, 2024
11 of 12 checks passed
@nikku nikku deleted the scroll-to-focused-element branch May 28, 2024 09:15
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants