Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify validation tests #253

Merged
merged 1 commit into from
Jul 5, 2023
Merged

test: simplify validation tests #253

merged 1 commit into from
Jul 5, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 5, 2023

We don't want to test the validation itself. We want to test what happens given a validation error is returned or not.


Follow-up to #252 (comment).

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 5, 2023
@philippfromme philippfromme requested a review from marstamm July 5, 2023 09:39
@philippfromme philippfromme marked this pull request as ready for review July 5, 2023 09:39
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 5, 2023
@fake-join fake-join bot merged commit b66923a into main Jul 5, 2023
@fake-join fake-join bot deleted the simplify-tests branch July 5, 2023 11:14
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants