fix(ListGroup): don't open on external changes #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
nikku
reviewed
Mar 23, 2023
| // open if not open and configured | ||
| if (!open && shouldOpen) { | ||
| // open if not open, configured and triggered by add button | ||
| if (addTriggered && !open && shouldOpen) { |
There was a problem hiding this comment.
Feels really like an awkward hack. Let's document it like that and add a // TODO(marstamm): ....
There was a problem hiding this comment.
I added a todo and a bit of documentation to move the logic out of the ListGroup
There was a problem hiding this comment.
Thanks @marstamm.
With these comments (and this commit as a reference) the changes look manageable.
Let's try to keep our hacks per LOC as low as possible.
marstamm
force-pushed
the
fix-listGroup-opening
branch
from
17ad378 to
e10d8c1
Compare
nikku
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on camunda/example-data-properties-provider#1, cf. https://camunda.slack.com/archives/GP70M0J6M/p1679407286325119
This ensures that we only open the section when the change originated from the
addbutton click: