-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose onFocus and onBlur functions on TextAreaEntry #191
Conversation
Hi @zhGio , thank you for opening this PR. It seems that this is missing from all components except Do you think it makes sense to add them to properties-panel/src/components/entries/TextField.js Lines 143 to 151 in 6075388
properties-panel/src/components/entries/FEEL/Feel.js Lines 313 to 325 in 6075388
|
Hi, @marstamm Yeah, I think it would make sense to expose those events to consumers on all components that render native components capable of focus/blur. I just ran into the issue of not having them on the |
Hi, |
Hi @marstamm, updated this PR with a lot more changes so if you could please review :) I've manually tested some of the examples and ran all the tests, seems ok to me. P.S. the force-push was me changing the author of the updated commit as i accidentally committed from my company account 😅 |
… of handling these events
13f9a5f
to
35692da
Compare
Thank you for the follow-up. CI is happy as well, so let's merge it 🚀 |
The inner component
TextArea
spreads theprops.onBlur
andprops.onFocus
functions to the native textarea component:But the outer component
TextAreaEntry
never actually exposes the same props to the consumer.