Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep first character of feel-required expression #184

Merged
merged 1 commit into from
Sep 16, 2022
Merged

fix: keep first character of feel-required expression #184

merged 1 commit into from
Sep 16, 2022

Conversation

marstamm
Copy link
Contributor

closes #183

Recording 2022-09-12 at 14 04 58 (1)

test it out:

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel -l bpmn-io/properties-panel#183-feel-required-cut-off -c "npm run start:cloud-templates"

@marstamm marstamm requested a review from a team September 12, 2022 12:14
@marstamm marstamm self-assigned this Sep 12, 2022
@marstamm marstamm requested review from pinussilvestrus and barmac and removed request for a team September 12, 2022 12:14
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 12, 2022
pinussilvestrus
pinussilvestrus approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@pinussilvestrus pinussilvestrus merged commit 0dd9fba into main Sep 16, 2022
@pinussilvestrus pinussilvestrus deleted the 183-feel-required-cut-off branch September 16, 2022 07:26
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The first character of the FEEL expression is cut off
2 participants
@marstamm @pinussilvestrus