Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first character of the FEEL expression is cut off #183

Closed
CatalinaMoisuc opened this issue Aug 24, 2022 · 0 comments · Fixed by #184
Closed

The first character of the FEEL expression is cut off #183

CatalinaMoisuc opened this issue Aug 24, 2022 · 0 comments · Fixed by #184
Assignees
@marstamm
Labels
bug Something isn't working

Comments

@CatalinaMoisuc
Copy link
Member

Describe the Bug

The first character of the FEEL expression is cut off after I unlink a template.
Funny enough, when I link the template back again, the values is displayed correctly so the value is there, but the editor is cutting it off.

Steps to Reproduce

  1. choose a connector or apply any element template that has some FEEL expression

  2. unlink the template

  3. then the first character of the feel expression is cut off

  4. reapply the template and the characters are back ✨

Issue reproduced in the Web Modeler:

Screen.Recording.2022-08-24.at.16.48.02.mov

Expected Behavior

The first character of the expression is not cut off.

Environment

  • Host Browser, if applicable: Chrome 104
  • OS: macOS Monterey
  • Library version: "camunda-bpmn-js": "0.16.1" > "@bpmn-io/properties-panel": "^0.18.0" > "@bpmn-io/feel-editor": "0.3.0"
@CatalinaMoisuc CatalinaMoisuc added the bug Something isn't working label Aug 24, 2022
@smbea smbea added the backlog Queued in backlog label Aug 31, 2022
@marstamm marstamm transferred this issue from bpmn-io/feel-editor Sep 12, 2022
marstamm added a commit that referenced this issue Sep 12, 2022
@marstamm
fix: keep first character of feel-required expression
a4e7f47 
closes #183
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 12, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Sep 12, 2022
@marstamm marstamm mentioned this issue Sep 12, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 12, 2022
@CatalinaMoisuc CatalinaMoisuc mentioned this issue Sep 13, 2022
Closed
pinussilvestrus pushed a commit that referenced this issue Sep 16, 2022
@marstamm
fix: keep first character of feel-required expression
0dd9fba 
closes #183
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 16, 2022
@marstamm marstamm mentioned this issue Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: keep first character of feel-required expression bpmn-io/properties-panel
3 participants
@marstamm @smbea @CatalinaMoisuc