feat: add Feel editor #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
force-pushed
the
feel-editor
branch
2 times, most recently
from
e3bef0e to
3b91f10
Compare
bpmn-io-tasks
bot
added
needs review
marstamm
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
|
This is ready to be reviewed. We should hold up merging it until after the 5.1 code freeze |
|
I'll schedule myself to review it tomorrow. |
|
Awesome! Let me know if you would like to have a sync session to go through the structure before you dive in yourself :) |
nikku
reviewed
Jul 8, 2022
nikku
reviewed
Jul 8, 2022
nikku
reviewed
Jul 8, 2022
nikku
reviewed
Jul 11, 2022
- export FeelTextAreaEntry - make all FEEL inputs resizeable
|
Broke after rebase on |
barmac
reviewed
Jul 11, 2022
| @@ -0,0 +1,11 @@ | |||
| import { useCallback, useRef } from 'preact/hooks'; | |||
|
|
|||
| export function useStaticCallback(callback) { | |||
There was a problem hiding this comment.
Let's add documentation for this.
There was a problem hiding this comment.
Added documentation explaining what it does and where we need it:
27452e0#diff-df9adc45b7ba0c5989414adedb44be602afd3e6745cf000be415f312751041ddR3-R16
barmac
reviewed
Jul 11, 2022
barmac
reviewed
Jul 11, 2022
barmac
approved these changes
Jul 13, 2022
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new Fields that support FEEL in InputFields and TextAreas. See the usage in the Properties Panel in this PR.
test it out the integration with
npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#feel-editor -l bpmn-io/properties-panel#feel-editor