Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Context): add DescriptionContext and useDescriptionContext #122

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

MaxTru
Copy link
Contributor

@MaxTru MaxTru commented Dec 7, 2021

related to #119

This will allow to have descriptions provided using a DescriptionContext.

This will allow to have the following in our upstream bpmn-js-prop-panel:

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 7, 2021
@MaxTru MaxTru force-pushed the descriptionContextSimple branch 3 times, most recently from 703dab5 to 9370965 Compare December 7, 2021 11:15
@MaxTru MaxTru marked this pull request as ready for review December 7, 2021 11:15
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 7, 2021
@MaxTru MaxTru force-pushed the descriptionContextSimple branch from 9370965 to 1ac0ff3 Compare December 7, 2021 11:16
@MaxTru MaxTru marked this pull request as draft December 7, 2021 11:26
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Dec 7, 2021
@MaxTru
Copy link
Contributor Author

MaxTru commented Dec 7, 2021

Converting to draft until I have the upstream change ready. Please feel free to already take a look.

MaxTru added a commit to bpmn-io/bpmn-js-properties-panel that referenced this pull request Dec 7, 2021
MaxTru added a commit to bpmn-io/bpmn-js-properties-panel that referenced this pull request Dec 7, 2021
@MaxTru MaxTru marked this pull request as ready for review December 7, 2021 19:52
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 7, 2021
@MaxTru
Copy link
Contributor Author

MaxTru commented Dec 7, 2021

Ready for review. See bpmn-io/bpmn-js-properties-panel#524 for how this can be used in upstream applications

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. 👏

@MaxTru MaxTru force-pushed the descriptionContextSimple branch from 1ac0ff3 to d5ad6af Compare December 7, 2021 20:34
@MaxTru MaxTru requested a review from nikku December 8, 2021 11:57
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@MaxTru MaxTru merged commit d7890cc into main Dec 8, 2021
@MaxTru MaxTru deleted the descriptionContextSimple branch December 8, 2021 12:05
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 8, 2021
MaxTru added a commit to bpmn-io/bpmn-js-properties-panel that referenced this pull request Dec 8, 2021
nikku pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants