-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Context): add DescriptionContext and useDescriptionContext #122
Conversation
703dab5
to
9370965
Compare
9370965
to
1ac0ff3
Compare
Converting to draft until I have the upstream change ready. Please feel free to already take a look. |
Ready for review. See bpmn-io/bpmn-js-properties-panel#524 for how this can be used in upstream applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. 👏
1ac0ff3
to
d5ad6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
related to #119
This will allow to have descriptions provided using a DescriptionContext.
This will allow to have the following in our upstream bpmn-js-prop-panel: