fix: FEEL text fields

bpmn-io · Feb 25, 2025 · fe044f4 · fe044f4
1 parent d8f833d
commit fe044f4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/src/components/entries/FEEL/Feel.js b/src/components/entries/FEEL/Feel.js
@@ -45,6 +45,7 @@ function FeelTextfieldComponent(props) {
     label,
     hostLanguage,
     onInput,
+    onBlur,
     onError,
     placeholder,
     feel,
@@ -130,6 +131,13 @@ function FeelTextfieldComponent(props) {
     }
   };
 
+  const handleOnBlur = e => {
+    if (onBlur) {
+      onBlur(e);
+    }
+    setLocalValue(e.target.value.trim());
+  };
+
   const handleLint = useStaticCallback((lint = []) => {
 
     const syntaxError = lint.some(report => report.type === 'Syntax Error');
@@ -256,6 +264,7 @@ function FeelTextfieldComponent(props) {
             { ...props }
             popupOpen={ popuOpen }
             onInput={ handleLocalInput }
+            onBlur={ handleOnBlur }
             contentAttributes={ { 'id': prefixId(id), 'aria-label': label } }
             value={ localValue }
             ref={ editorRef }
@@ -314,7 +323,7 @@ const OptionalFeelInput = forwardRef((props, ref) => {
     class="bio-properties-panel-input"
     onInput={ e => onInput(e.target.value) }
     onFocus={ onFocus }
-    onBlur={ onBlur }
+    onBlur={ e => onBlur(e) }
     placeholder={ placeholder }
     value={ value || '' } />;
 });
@@ -411,7 +420,7 @@ const OptionalFeelTextArea = forwardRef((props, ref) => {
     class="bio-properties-panel-input"
     onInput={ e => onInput(e.target.value) }
     onFocus={ onFocus }
-    onBlur={ onBlur }
+    onBlur={ e => onBlur(e) }
     placeholder={ placeholder }
     value={ value || '' }
     data-gramm="false"

diff --git a/test/spec/components/Feel.spec.js b/test/spec/components/Feel.spec.js
@@ -1871,6 +1871,27 @@ describe('<FeelField>', function() {
     });
 
 
+    it('should have no trailing spaces', async function() {
+
+      // given
+      const result = createFeelField({ container });
+
+      const input = domQuery('.bio-properties-panel-input', result.container);
+
+      // when
+      changeInput(input, 'foo    ');
+
+      input.focus();
+      input.blur();
+
+      // then
+      await waitFor(() => {
+        expect(input.value).to.equal('foo');
+      });
+
+    });
+
+
     describe('#isEdited', function() {
 
       it('should NOT be edited', function() {