Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow defining FEEL Popup container #795

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Allow defining FEEL Popup container #795

merged 3 commits into from
Sep 14, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Sep 7, 2023 •
edited
Loading

Depends on bpmn-io/properties-panel#280
Related to https://github.com/camunda/team-hto/issues/344
Required by camunda/form-playground#101

This allows to provide a feel popup container via config.

new FormPlayground({
  data,
  schema,
  propertiesPanel: {
    feelPopupContainer: rootRef.current
  },
});

Demo: https://feel-popup-root--camunda-form-playground.netlify.app/

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 7, 2023
This was referenced Sep 7, 2023
Merged
Merged
@pinussilvestrus pinussilvestrus marked this pull request as ready for review September 11, 2023 11:33
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 11, 2023
Skaiir
Skaiir approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires conflict resolutions due to pressing the button on groups I reckon 👀

@pinussilvestrus pinussilvestrus merged commit 7e1864a into develop Sep 14, 2023
@pinussilvestrus pinussilvestrus deleted the feel-popup-root branch September 14, 2023 07:41
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsgoulart vsgoulart vsgoulart approved these changes

@Skaiir Skaiir Skaiir approved these changes

Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinussilvestrus @vsgoulart @Skaiir