Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export external styles #677

Closed
pinussilvestrus opened this issue Jun 5, 2023 · 2 comments · Fixed by #678
Closed

Re-export external styles #677

pinussilvestrus opened this issue Jun 5, 2023 · 2 comments · Fixed by #678
Assignees
@pinussilvestrus

Comments

@pinussilvestrus
Copy link
Contributor

What should we do?

With v0.13 we removed the external styles exports coming from integrated libraries and bundle everything together. However, there are use cases that could benefit from still including styles per-file, and optionally remove not needed stylesheets.

We should add the exports again to make such use cases possible again.

Why should we do it?

Context: bpmn-io/properties-panel#249 (comment)
@pinussilvestrus pinussilvestrus mentioned this issue Jun 5, 2023
Closed
@pinussilvestrus
Copy link
Contributor Author

@Skaiir @vsgoulart I think it makes sense to consider this before v1 .0.0 is stable. The integration into web-modeler shows that it could be beneficial to bring back these exports.

cc @christian-konrad @marcosgvieira

pinussilvestrus pushed a commit that referenced this issue Jun 5, 2023
chore(distro): re-export external library styles
7c6d875 
Closes #677
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 5, 2023
@pinussilvestrus pinussilvestrus mentioned this issue Jun 5, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2023
pinussilvestrus pushed a commit that referenced this issue Jun 5, 2023
chore(distro): re-export external library styles
4de19fa 
Closes #677
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 5, 2023
@pinussilvestrus
Copy link
Contributor Author

Released via [email protected] in case we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(distro): re-export external library styles bpmn-io/form-js
1 participant
@pinussilvestrus