Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict tooltip placement #32

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Restrict tooltip placement #32

merged 3 commits into from
Nov 21, 2022

Conversation

marstamm
Copy link
Collaborator

Allows us to optionally add a container element where tooltips will be placed.

Recording 2022-11-18 at 16 26 25

related to camunda/camunda-modeler#3216

Try it out on the properties-panel feature branch:
npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#restrict-feel-tooltip-placement

@marstamm marstamm requested a review from a team November 18, 2022 15:43
@marstamm marstamm self-assigned this Nov 18, 2022
@marstamm marstamm requested review from philippfromme and removed request for a team November 18, 2022 15:43
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 18, 2022
@marstamm marstamm requested a review from smbea November 18, 2022 15:43
@philippfromme
Copy link
Contributor

philippfromme commented Nov 21, 2022 •
edited
Loading

I tried out the feature branch and noticed that the FEEL editor loses focus whenever I type (I disabled Grammarly so it's not that). Does it work for you, @marstamm?

brave_UeKEiwijLi

@marstamm
Copy link
Collaborator Author

I can reproduce it. The issue was the way we create the context in the properties-panel (cf. bpmn-io/bpmn-js-properties-panel@b1bb196)

@marstamm
Copy link
Collaborator Author

Should be fixed now

philippfromme
philippfromme approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@fake-join fake-join bot merged commit 9b34e5a into main Nov 21, 2022
@fake-join fake-join bot deleted the restrict-tooltip-placement branch November 21, 2022 11:42
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2022
@marstamm marstamm mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marstamm @philippfromme