Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existing parameter suggested for parameterless functions #898

Closed
barmac opened this issue Sep 23, 2024 · 2 comments · Fixed by #899
Closed

Non-existing parameter suggested for parameterless functions #898

barmac opened this issue Sep 23, 2024 · 2 comments · Fixed by #899
Assignees
Labels
bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented Sep 23, 2024

Describe the Bug

Starting with 732c5cd, the literal expression editor adds non-existing param 1 to the suggestions of functions which don't take parameters:

Screenshot 2024-09-23 at 13 27 45

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start writing today
  2. Notice param 1 in the signature.

If you report a modeling related issue, ensure you can reproduce it on demo.bpmn.io

When reporting a library error, try to build an example that reproduces your problem. You can use our playgrounds for viewer or modeler as a starting point or put a demo up on GitHub for inspection.

Expected Behavior

A clear and concise description of what you expected to happen.

Environment

Please complete the following information:

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: v16.7.0 and later

Additional context

Reported via Slack (thanks @falko): https://camunda.slack.com/archives/C01QYD808A3/p1724913814192189

The bad commit included an update of feel-editor which I suspect to break the suggestion:

     "node_modules/@bpmn-io/feel-editor": {
-      "version": "1.4.0",
-      "resolved": "https://registry.npmjs.org/@bpmn-io/feel-editor/-/feel-editor-1.4.0.tgz",
-      "integrity": "sha512-xfkvacymlQhS45Y4HF5PKmN0O1VMp5KDzBps4JSKEfNfIFEcvpAbOwYcXSmg3nqv6s+Rdyor4lPLgwiA+bqC8Q==",
+      "version": "1.7.0",
+      "resolved": "https://registry.npmjs.org/@bpmn-io/feel-editor/-/feel-editor-1.7.0.tgz",
+      "integrity": "sha512-ZvppAXVVcGtuXWpj0oKgK8DP8TF0GRUdLrH08+FTEreOcD7oY4I69YlzWj1uTYART4sxD9sgMQPsLPorPo2lbQ==",
+      "license": "MIT",
@barmac barmac added the bug Something isn't working label Sep 23, 2024
barmac added a commit to bpmn-io/feel-editor that referenced this issue Sep 23, 2024
This makes sure we don't show non-existing params for functions
like "now()" or "today()".

Related to bpmn-io/dmn-js#898
@barmac
Copy link
Member Author

barmac commented Sep 23, 2024

This will be fixed via bpmn-io/feel-editor#63

@barmac barmac self-assigned this Sep 23, 2024
nikku pushed a commit to bpmn-io/feel-editor that referenced this issue Sep 23, 2024
This makes sure we don't show non-existing params for functions
like "now()" or "today()".

Related to bpmn-io/dmn-js#898
@nikku
Copy link
Member

nikku commented Sep 23, 2024

@nikku nikku added the fixed upstream Requires integration of upstream change label Sep 23, 2024
nikku added a commit that referenced this issue Sep 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 23, 2024
barmac pushed a commit that referenced this issue Sep 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants