Render popup menu in .djs-container
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding bpmn-io/bpmn-js#1795 (comment): Any reason we don't simply attach it to |
|
The reason would be to make it configurable generally speaking, but actually I don't have a concrete use case. |
Let's keep that (at least the class being present). No need to revert, causing another breaking change. |
smbea
force-pushed
the
fix-popup-menu-parent
branch
from
8672253 to
f2c3900
Compare
|
Makes sense to me. Feel free to have another look |
nikku
reviewed
Jan 5, 2023
smbea
force-pushed
the
fix-popup-menu-parent
branch
from
f2c3900 to
9d5129f
Compare
nikku
force-pushed
the
fix-popup-menu-parent
branch
from
9d5129f to
5a1458d
Compare
|
Added a test case. |
nikku
approved these changes
Jan 5, 2023
nikku
changed the title
.djs-container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/bpmn-js#1795
See comment bpmn-io/bpmn-js#1795 (comment).