Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CHANGELOG to v11.0.0 #694

Merged
merged 1 commit into from
Nov 18, 2022
Merged

update CHANGELOG to v11.0.0 #694

merged 1 commit into from
Nov 18, 2022

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Nov 15, 2022

Context: release new popup menu to be integrated into bpmn-js

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 15, 2022
@smbea smbea requested review from a team, marstamm and barmac and removed request for a team November 15, 2022 12:54
barmac
barmac reviewed Nov 15, 2022
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 17 to 18
* Improved popup menu UI and behaviour, resulting in the modification of some of the composing HTML elements and CSS classes.
* The popup menu now exists outside of the canvas container. The `djs-parent` class was introduced to the canvas and popup menu roots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's answer here two questions:

  1. What is breaking?
  2. How do I migrate to new version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this

@nikku
Copy link
Member

nikku commented Nov 15, 2022

Let us release a pre-release first to incorporate in bpmn-js.

I'd love to get #681 incorporated, too, which may be a breaking change (depending on how we spin it).

@smbea
Copy link
Contributor Author

smbea commented Nov 15, 2022 •
edited
Loading

Let us release a pre-release first to incorporate in bpmn-js.

@nikku What would this look like in terms of versioning? Something like v11.0.0-alpha.0?

@nikku
Copy link
Member

nikku commented Nov 15, 2022

Yes, cf. https://www.npmjs.com/package/diagram-js?activeTab=versions.

To be published on the next tag so users don't accidentally consume it.

@smbea
Copy link
Contributor Author

smbea commented Nov 15, 2022

Setting this as draft and doing a pre-release for now. Will come back to this when we are ready for stable release

@smbea smbea marked this pull request as draft November 15, 2022 13:30
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 15, 2022
@barmac
Copy link
Member

barmac commented Nov 15, 2022

Let us release a pre-release first to incorporate in bpmn-js.

I'd love to get #681 incorporated, too, which may be a breaking change (depending on how we spin it).

I'll look into this as the contributor seems to be not active anymore.

@barmac
Copy link
Member

barmac commented Nov 15, 2022

Let us release a pre-release first to incorporate in bpmn-js.
I'd love to get #681 incorporated, too, which may be a breaking change (depending on how we spin it).

I'll look into this as the contributor seems to be not active anymore.

It's merged now.

@smbea
Copy link
Contributor Author

smbea commented Nov 16, 2022 •
edited
Loading

Will also wait for #696. Feel free to already review the changes to the breaking changes text

@smbea smbea marked this pull request as ready for review November 18, 2022 10:08
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 18, 2022
smbea
smbea commented Nov 18, 2022
View reviewed changes
CHANGELOG.md Outdated
* `FEAT`: drop KeyboardEvent.keyCode in favor of `code` ([#681](https://github.com/bpmn-io/diagram-js/pull/681))
* `FEAT`: introduction of `.djs-parent` class to canvas and popup menu root ([#687](https://github.com/bpmn-io/diagram-js/pull/687))
* `FEAT`: new popupMenu UI featuring menu and group titles, search, entry descriptions and documentation urls ([#687](https://github.com/bpmn-io/diagram-js/pull/687), [#696](https://github.com/bpmn-io/diagram-js/pull/696), [#697](https://github.com/bpmn-io/diagram-js/pull/697), [#699](https://github.com/bpmn-io/diagram-js/pull/699))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of only valuable changes to the CHANGELOG and since this is a whole new feature, I added the main PR and small follow-us as one topic. Let me know what you think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we link the issue if it's in the same repo. In this case, you could link #686

@smbea smbea requested a review from barmac November 18, 2022 10:10
nikku
nikku reviewed Nov 18, 2022
View reviewed changes
nikku
nikku reviewed Nov 18, 2022
View reviewed changes
@smbea @nikku @barmac
chore(CHANGELOG): update to v11.0.0
0a592ef 
Co-Authored-By: Nico Rehwaldt <[email protected]>
Co-Authored-By: Maciej Barelkowski <[email protected]>
@smbea smbea merged commit 4c519a6 into develop Nov 18, 2022
@smbea smbea deleted the update-to-11.0.0 branch November 18, 2022 13:13
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku left review comments

@barmac barmac barmac approved these changes

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smbea @nikku @barmac