Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context-pad): ensure context pad is always in front #576

Closed
wants to merge 2 commits into from

Conversation

philippfromme
Copy link
Contributor

In dmn-js

b6df0Xab05


Related to bpmn-io/dmn-js#657

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 14, 2021
@nikku
Copy link
Member

nikku commented Oct 14, 2021

How to reproduce this within diagram-js? Can you construct a simple (visual) test case?

@philippfromme
Copy link
Contributor Author

@nikku I've modified a test case to reproduce it.

image

We just need to remove it before merging.

@nikku
Copy link
Member

nikku commented Oct 14, 2021

Thanks. You could have also left that as an actual visual integration test in the code base, too. 🙂

@nikku
Copy link
Member

nikku commented Oct 14, 2021

Closed via 370ecb9.

@nikku nikku closed this Oct 14, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 14, 2021
@nikku nikku deleted the 657-context-pad-fix branch October 14, 2021 11:45
@philippfromme
Copy link
Contributor Author

Thanks. You could have also left that as an actual visual integration test in the code base, too. 🙂

Ah, I wasn't sure whether that was what you meant. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants