Introduce frame elements #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pinussilvestrus
force-pushed
the
frames-v2
branch
from
c4e95f4 to
7b5b0df
Compare
pinussilvestrus
changed the title
|
Note for the reviewer: To test in a modeling manner, please refer to the |
nikku
reviewed
Apr 30, 2019
nikku
reviewed
Apr 30, 2019
nikku
reviewed
Apr 30, 2019
pinussilvestrus
changed the title
|
Thanks for reviewing! I'll check whether we can rid of the extra stuff by adding the |
pinussilvestrus
force-pushed
the
frames-v2
branch
from
7b5b0df to
0edf79d
Compare
pinussilvestrus
changed the title
nikku
reviewed
Apr 30, 2019
pinussilvestrus
force-pushed
the
frames-v2
branch
2 times, most recently
from
4e0c780 to
9d81e48
Compare
Makes frame elements only interactable on the stroke Relates to bpmn-io/bpmn-js#959 Relates to bpmn-io/bpmn-js#960
* remove Grund in favor of Webpack * simplify
philippfromme
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces basic frame elements support
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
Frame Interaction
Prevent dropping on borders
Note
We decided to not include the second (inner) outline to frame element borders, since it could lead to confusions (other tools does not offer it at all). Furthermore, right now we only think about rectangles as possible frame elements. The inner square outline would look weird with circle elements (e.g. when creating custom elements).
Let's try out whether only one outline is enough for the user to determine border-only interaction. When we find out that this is confusing, we could add it in a second iteration. I moved the code to a standalone extension (cf.
diagram-js-frame-outline)