Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scheduler tests consistently failing on CI (Linux, Firefox) #921

Closed
nikku opened this issue Jul 4, 2024 · 2 comments · Fixed by #922
Closed

Fix Scheduler tests consistently failing on CI (Linux, Firefox) #921

nikku opened this issue Jul 4, 2024 · 2 comments · Fixed by #922
Assignees
@nikku
Labels
test

Comments

@nikku
Copy link
Member

nikku commented Jul 4, 2024

What should we do?

As mentioned by @marstamm in #920 (comment) the CI tests consistently fail on Linux, Firefox after the introduction of the scheduler f7b95f2#diff-4b07ab4f15eebbd591cbc13b0b12a96714c31f1caf51176504a929aa98dec27fR17.

The initial version of the scheduler tests passed CI; I'm not sure how we could miss the new version of the tests failing on Firefox. We want to investigate what's up and ensure our CI is stable, green, again.

Why should we do it?

Ensure our CI is reliable.
@nikku nikku added test ready Ready to be worked on labels Jul 4, 2024
@nikku nikku mentioned this issue Jul 4, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 4, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jul 4, 2024
@nikku
Copy link
Member Author

nikku commented Jul 4, 2024

I investigated this locally and can reproduce the issue. In isolation the tests run just fine:

image

Work in progress draft PR up at #922.

@nikku nikku added the ready Ready to be worked on label Aug 21, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Aug 21, 2024
@nikku nikku mentioned this issue Oct 1, 2024
Merged
4 tasks
nikku added a commit that referenced this issue Oct 1, 2024
@nikku
fix(scheduler): use setTimeout to reliably off-load work
8f33e8b 
Requests to requestAnimationFrame may be dropped, depending on
how the browser feels. If we want to reliably ensure work gets done,
we have to setTimeout(work) things.

Closes #921
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Oct 1, 2024
@nikku nikku changed the title Investigate Scheduler tests consistently failing on CI (Linux, Firefox) Fix Scheduler tests consistently failing on CI (Linux, Firefox) Oct 2, 2024
@nikku
Copy link
Member Author

nikku commented Oct 2, 2024

Cf. #922 (comment)

@nikku nikku closed this as completed in #922 Oct 2, 2024
nikku added a commit that referenced this issue Oct 2, 2024
@nikku
fix(scheduler): use setTimeout to reliably off-load work
99af140 
Requests to requestAnimationFrame may be dropped, depending on
how the browser feels. If we want to reliably ensure work gets done,
we have to setTimeout(work) things.

Closes #921
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use setTimeout for async work bpmn-io/diagram-js
1 participant
@nikku