Skip to content

Commit

Permalink
chore(popup-menu): make always draggable
Browse files Browse the repository at this point in the history
Prevents ugly text selection effect / artifact if entry does not feature a drag action.
  • Loading branch information
nikku committed Jan 16, 2023
1 parent c392882 commit cd54e51
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lib/features/popup-menu/PopupMenuItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ export default function PopupMenuItem(props) {
onAction
} = props;

const draggable = entry.action && entry.action.dragstart;

return html`
<li
class=${ classNames('entry', { selected }) }
Expand All @@ -35,7 +33,7 @@ export default function PopupMenuItem(props) {
onMouseEnter=${ onMouseEnter }
onMouseLeave=${ onMouseLeave }
onDragStart=${ (event) => onAction(event, entry, 'dragstart') }
draggable=${ draggable }
draggable=${ true }
>
<div class="djs-popup-entry-content">
<span
Expand Down

0 comments on commit cd54e51

Please sign in to comment.