feat(renderer): allow passing of attrs

closes #578
bpmn-io · Oct 25, 2021 · c290d6a · c290d6a
1 parent 5bff78e
commit c290d6a
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 8 deletions.
diff --git a/lib/draw/BaseRenderer.js b/lib/draw/BaseRenderer.js
@@ -14,13 +14,14 @@ export default function BaseRenderer(eventBus, renderPriority) {
   eventBus.on([ 'render.shape', 'render.connection' ], renderPriority, function(evt, context) {
     var type = evt.type,
         element = context.element,
-        visuals = context.gfx;
+        visuals = context.gfx,
+        attrs = context.attrs;
 
     if (self.canRender(element)) {
       if (type === 'render.shape') {
-        return self.drawShape(visuals, element);
+        return self.drawShape(visuals, element, attrs);
       } else {
-        return self.drawConnection(visuals, element);
+        return self.drawConnection(visuals, element, attrs);
       }
     }
   });

diff --git a/lib/draw/DefaultRenderer.js b/lib/draw/DefaultRenderer.js
@@ -13,6 +13,8 @@ import {
   create as svgCreate
 } from 'tiny-svg';
 
+import { assign } from 'min-dash';
+
 import {
   isFrameElement
 } from '../util/Elements';
@@ -44,7 +46,7 @@ DefaultRenderer.prototype.canRender = function() {
   return true;
 };
 
-DefaultRenderer.prototype.drawShape = function drawShape(visuals, element) {
+DefaultRenderer.prototype.drawShape = function drawShape(visuals, element, attrs) {
   var rect = svgCreate('rect');
 
   svgAttr(rect, {
@@ -55,19 +57,19 @@ DefaultRenderer.prototype.drawShape = function drawShape(visuals, element) {
   });
 
   if (isFrameElement(element)) {
-    svgAttr(rect, this.FRAME_STYLE);
+    svgAttr(rect, assign({}, this.FRAME_STYLE, attrs || {}));
   } else {
-    svgAttr(rect, this.SHAPE_STYLE);
+    svgAttr(rect, assign({}, this.SHAPE_STYLE, attrs || {}));
   }
 
   svgAppend(visuals, rect);
 
   return rect;
 };
 
-DefaultRenderer.prototype.drawConnection = function drawConnection(visuals, connection) {
+DefaultRenderer.prototype.drawConnection = function drawConnection(visuals, connection, attrs) {
 
-  var line = createLine(connection.waypoints, this.CONNECTION_STYLE);
+  var line = createLine(connection.waypoints, assign({}, this.CONNECTION_STYLE, attrs || {}));
   svgAppend(visuals, line);
 
   return line;

diff --git a/test/spec/draw/DefaultRendererSpec.js b/test/spec/draw/DefaultRendererSpec.js
@@ -2,6 +2,7 @@ import {
   bootstrapDiagram,
   inject
 } from 'test/TestHelper';
+import { create } from 'tiny-svg';
 
 import drawModule from 'lib/draw';
 
@@ -93,4 +94,51 @@ describe('draw - DefaultRenderer', function() {
 
   });
 
+
+  describe('#drawShape', function() {
+
+    var gfx;
+
+    beforeEach(function() {
+      gfx = create('svg');
+    });
+
+
+    it('should have default style', inject(function(eventBus) {
+
+      // given
+      var element = {
+        id: 'shapeA',
+        x: 100, y: 100, width: 100, height: 100
+      };
+
+      // when
+      var shape = eventBus.fire('render.shape', { gfx: gfx, element: element });
+
+      // then
+      expect(shape.style.strokeWidth).to.eql('2px');
+
+    }));
+
+
+    it('should apply supplied styles', inject(function(eventBus) {
+
+      // given
+      var element = {
+        id: 'shapeA',
+        x: 100, y: 100, width: 100, height: 100
+      };
+
+      var attrs = { strokeWidth: '10px' };
+
+      // when
+      var shape = eventBus.fire('render.shape', { gfx: gfx, element: element, attrs: attrs });
+
+      // then
+      expect(shape.style.strokeWidth).to.eql('10px');
+
+    }));
+
+  });
+
 });